Rename patched filters so the normalizer uses the default ones #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgresshoff
force-pushed
the
bug/408-fix-acronyms-with-diacritics
branch
from
0e369eb
to
d3c20ca
Compare
invenio_vocabularies/contrib/funders/mappings/os-v2/funders/funder-v2.0.0.json
Outdated
Show resolved
Hide resolved
sakshamarora1
approved these changes
Oct 8, 2024
wgresshoff
force-pushed
the
bug/408-fix-acronyms-with-diacritics
branch
from
d6f3378
to
ae3b4f2
Compare
kpsherva
reviewed
Oct 14, 2024
| @@ -14,8 +14,8 @@ | |||
| "type": "custom", | |||
| "char_filter": ["strip_special_chars"], | |||
| "filter": [ | |||
| "lowercase", | |||
| "asciifolding", | |||
| "lowercasepreserveoriginal", | |||
There was a problem hiding this comment.
@wgresshoff could I ask you to move all the changes to funder-v3.0.0.json files?
in case of breaking changes like these we need to upgrade the version of the mapping, otherwise instance upgrades are complex
so we need to (for both os-v1 and os-v2)
- copy the mappings to funder-v3.0.0.json
- move the changes you proposed here to funder-v3.0.0.json file
- revert funders-v2.0.0.json changes
There was a problem hiding this comment.
Since in practice this doesn't break existing indices created with the old mapping but only affects search behavior/accuracy, I feel we can merge without bumping the mapping version.
This means that for deployment, one needs to either:
- Do the usual recreation of indices (with downtime)
- Do a live migration with some special handling since the old and new index name will be the same (only the timestamp suffix changes).
There was a problem hiding this comment.
We used the recreation of indices with downtime and the missing funders were reindexed without problem.
wgresshoff
force-pushed
the
bug/408-fix-acronyms-with-diacritics
branch
from
ae3b4f2
to
6cbca0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Close #408
Description
The normalizer that was introduced in the funders index with v5.1.0 generates two tokens when used on documents that contain diacritics in the acronym. This behaviour occurs when in the filter definition
"preserve_original": trueis used. This is ok for analyzers, so this PR just renames the filters and takes care the analyzers use the new ones and the normailzer uses the original ones.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: